bin/brew: re-exec self under Rosetta if needed #9287
Closed
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in Homebrew#9177, we've reserved /usr/local as the prefix to use on Apple Silicon Macs for an Intel installation of Homebrew to be run under Rosetta. If a user has a /usr/local installation on an Apple Silicon Mac, and executes /usr/local/bin/brew, we should make sure we're running that copy of brew as Intel under emulation in order to avoid confusion. This makes that change.
|
Review period will end on 2020-11-26 at 01:48:37 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
requested changes
Nov 25, 2020
There was a problem hiding this comment.
A few concerns:
- Will this succeed if Rosetta isn't installed?
- This will avoid the existing prefix messaging from ever being displayed for
/usr/localwhich is undesirable. - If the existing
/usr/localhad some ARM software installed in it this will produce confusing errors later on. - I'd rather we avoided hardcoding
/usr/localin another place here. - It feels like there's a bit of overlap here with Check flavour to prevent mixed architectures #9126.
An alternate approach I'd rather (which overlaps with #9126) is changing or tweaking the existing error messages to make it more clear what needs to be done and how to do it. Doing so automatically without prompt or notification seems dangerous. Perhaps having an environment variable which has this behaviour (in brew.sh not bin/brew) would be an acceptable workaround after #9126 is finished and merged (or closed)
3 tasks
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Nov 26, 2020
jasonchaw
approved these changes
Nov 28, 2020
This was referenced Dec 4, 2020
|
Closing in favour of #9418 ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?As discussed in #9177, we've reserved
/usr/localas the prefix to use on Apple Silicon Macs for an Intel installation of Homebrew to be run under Rosetta.If a user has a
/usr/localinstallation on an Apple Silicon Mac, and executes/usr/local/bin/brew, we should make sure we're running that copy ofbrewas Intel under emulation in order to avoid confusion. This makes that change.cc #9126
cc @claui, @MikeMcQuaid